The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Review	Updated (UTC)
docs	Skipped		Jan 18, 2026 2:58am

Greptile Summary

This PR introduces a general abstraction for enriching agent context with runtime-dependent schema information, with the primary use case being Knowledge Base tags. The implementation consolidates visibility helpers and improves parameter handling across the codebase.

Key Changes:

• Created schema-enrichers.ts with enrichKBTagsSchema() and enrichKBTagFiltersSchema() to dynamically fetch KB tag definitions and build schemas for LLM consumption
• Added SchemaEnrichmentConfig interface to ToolConfig allowing tools to declare parameters that need runtime schema enrichment based on dependency values
• Consolidated visibility helper functions into params-resolver.ts for reuse across UI and executor contexts
• Replaced static tag parameters (tag1-tag7) in create_document tool with dynamic documentTags parameter using schema enrichment
• Added tag parsing utilities (parseDocumentTags, parseTagFilters) to handle various input formats from UI and LLM
• Migrated tag definitions API endpoint to hybrid auth to support internal JWT access from executors
• Improved isDeployedContext propagation through handlers and changed workflow executor to use it instead of triggerType
• Enhanced UI components to use previewContextValues for proper dependency resolution with canonical parameters

Issues Found:

• Logic issue in resolveSubBlockForParam where fallback matching could miss valid subblocks with different conditions
• Missing validation for empty dependency values in schema enrichment could cause unnecessary API calls
• Type validation for boolean tag values could be stricter to prevent malformed data

Confidence Score: 4/5

• Safe to merge with minor issues - the logic bugs identified are edge cases that may not occur in typical usage
• The PR implements a solid abstraction pattern with good test coverage (workflow executor tests updated). However, there are a few logic edge cases in parameter resolution and validation that should be addressed. The schema enrichment pattern is well-designed and the consolidation of visibility helpers improves maintainability. The auth changes for tag definitions API are appropriate for internal executor access.
• Review apps/sim/tools/params.ts for the logic issues in resolveSubBlockForParam and enrichment validation

Important Files Changed

Sequence Diagram

sequenceDiagram
    participant UI as Tool Input UI
    participant Store as Block Store
    participant Params as params.ts
    participant Enricher as schema-enrichers.ts
    participant API as Tag Definitions API
    participant Handler as Agent Handler
    participant Provider as Provider Utils
    participant Tool as Tool Execution

    Note over UI,Store: User configures KB ID
    UI->>Store: Set knowledgeBaseId
    
    Note over UI,Params: Build preview context
    UI->>Params: buildPreviewContextValues()
    Params-->>UI: Resolved canonical values
    
    Note over UI,API: Fetch tag definitions for UI
    UI->>API: GET /api/knowledge/{id}/tag-definitions
    API-->>UI: Tag definitions array
    UI->>UI: Render document-tag-entry/tag-filters
    
    Note over Handler,Tool: Agent executes tool with params
    Handler->>Provider: prepareToolExecution(tool, llmArgs)
    Provider->>Params: mergeToolParameters(userParams, llmArgs)
    Params-->>Provider: Merged tool params
    
    Note over Provider,Tool: Create LLM tool schema
    Provider->>Params: createLLMToolSchema(toolConfig, userParams)
    Params->>Params: Check schemaEnrichment config
    
    alt documentTags/tagFilters has enrichment
        Params->>Enricher: enrichKBTagsSchema(knowledgeBaseId)
        Enricher->>API: GET /api/knowledge/{id}/tag-definitions
        API-->>Enricher: Tag definitions
        Enricher-->>Params: Dynamic schema with KB tags
        Params-->>Provider: LLM schema with enriched params
    end
    
    Provider->>Tool: Execute with merged params + enriched schema
    
    Note over Tool,Params: Parse and normalize tags
    Tool->>Params: parseDocumentTags(value)
    Params-->>Tool: Normalized tag entries
    Tool->>Params: formatDocumentTagsForAPI(tags)
    Params-->>Tool: documentTagsData JSON
    
    Tool-->>Handler: Tool execution result

@greptile

@greptile